Attention is currently required from: lynxis lazus.
osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28652 )

Change subject: debian: rework packaging
......................................................................


Patch Set 1:

(3 comments)

Patchset:

PS1:
Thanks, this is much cleaner! LGTM besides the "rm -rf" command


File debian/osmo-diameter2gsup.install:

https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28652/comment/5f2a65c9_6beb3762
PS1, Line 2: /_build/default/bin/osmo-dia2gsup /usr/bin/
does it still start with the systemd service? I'm not familiar at all with 
erlang, I though the other libraries were needed at runtime


File debian/rules:

https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28652/comment/3c0c5986_e1a47d4d
PS1, Line 18: _lib
_lib doesn't get created anymore:

  rm -rf _build



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28652
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: I40add168875de87ef0cc62deeb5377d2ce080e45
Gerrit-Change-Number: 28652
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Tue, 19 Jul 2022 10:43:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to