Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28725 )
Change subject: Introduce APDU/TPDU trace decoder ...................................................................... Patch Set 1: (2 comments) File pySim/gsmtap.py: https://gerrit.osmocom.org/c/pysim/+/28725/comment/a23abdea_c457679f PS1, Line 153: Int8ub > I would use Const(b'\x02') to enforce GSMTAPv2 (GSMTAP_VERSION). Well, the check in the code allows us to be more flexible, I think it's one of those situation where I can't say one is clearly better than the other. File pySim/ts_31_102.py: https://gerrit.osmocom.org/c/pysim/+/28725/comment/747256b9_e697db5a PS1, Line 303: # 3gPP TS 31.102 Section 7.5.2.1 > unrelated? why is it unrelated? That DataObject is referenced in the tracer: pySim/apdu/ts_31_102.py:from pySim.ts_31_102 import SUCI_TlvDataObject -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I862d93163d495a294364168f7818641e47b18c0a Gerrit-Change-Number: 28725 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Fri, 22 Jul 2022 10:42:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
