Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28754 )
Change subject: apply code review: refactor pfcp_endpoint API ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > You are improving the state ofn things halfway, since you implemented some > API getters/setter for so […] the pattern of a struct to pass user provided config is used in many other places. maybe it is apparent, i'm having difficulty accepting this code review... it feels a bit like the way i have done things for years is now considered wrong, and it is causing a lot of work on top of the pile of tasks i am trying to complete. how about the 'bool more_items' way to ensure ABI compat, like used in libosmocore/include/osmocom/gsm/gsm0808.h -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: If80c35c6a942bf9593781b5a6bc28ba37323ce5e Gerrit-Change-Number: 28754 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 25 Jul 2022 11:53:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
