Attention is currently required from: fixeria.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/28744 )

Change subject: trxcon: make l1sched logging configurable, append trxcon->fi 
prefix
......................................................................


Patch Set 2:

(2 comments)

Patchset:

PS2:
> Yes, this is useful when trxcon has multiple L1CTL connections 
> (ttcn3-bts-test will be using this so […]
Yes, if you want to identify each l1sched, then add an "id" or "name" field to 
it, and fill it once easily with an API.


File src/host/trxcon/src/sched_lchan_tchh.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/28744/comment/434123e1_4ac4e59b
PS2, Line 185: #if 0
> Because no logging context is available here: neither sched, nor lchan.
So why don't you print without logging context? or is that prohibited by some 
sort of religion I'm unaware of?



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28744
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I26da1a506b02502a3a6a887533c35fb09c13c429
Gerrit-Change-Number: 28744
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 25 Jul 2022 12:15:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to