Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 )
Change subject: add library/PFCP_*, deps/PFCP ...................................................................... Patch Set 3: (2 comments) File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/377dd1d4_ffb79257 PS1, Line 418: function ts_PFCP_Session_Est_Req(charstring node_id, OCT8 cp_seid, Create_PDR_list create_pdr, Create_FAR_list create_far) return template PDU_PFCP { > the thing that annoys me there is that universal-ctags in general does a good > job of taging ttcn3, b […] I'm sorry but your personal tooling is not an acceptable motivation to avoid specifying template types properly, which affects everybody else. It shows a lot of errors and also makes stuff more difficult when using them due to constrictions. Think of it as if it was a const pointer mark, or a nullable pointer mark. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/25670c34_8ea44096 PS1, Line 460: function tr_PFCP_Session_Est_Resp(template OCT8 hdr_seid := ?) return template PDU_PFCP { > why? Can it be "omit"? then "template (omit)", otherwise "template (present)". You see, they serve to actually provide information on what can be passed to it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Thu, 28 Jul 2022 14:43:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
