laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/28877 )
Change subject: sbcap: Fix NULL pointer dereference
......................................................................
sbcap: Fix NULL pointer dereference
Related: Coverity CID#275347
Change-Id: I9ae1cad4ce4e3fe6cfd67ac6058fb7345a3dd49e
---
M src/sbcap_link_fsm.c
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/sbcap_link_fsm.c b/src/sbcap_link_fsm.c
index 685ce7d..3b929ed 100644
--- a/src/sbcap_link_fsm.c
+++ b/src/sbcap_link_fsm.c
@@ -302,12 +302,13 @@
LOGPSBCAPC(link, LOGL_ERROR, "SBcAP initiatingMessage
procedure=%ld not implemented?\n",
pdu->choice.initiatingMessage.procedureCode);
err_ind_pdu = sbcap_gen_error_ind(link,
SBcAP_Cause_valid_message_not_identified, pdu);
- if (err_ind_pdu)
- cbc_sbcap_link_tx(link, err_ind_pdu);
- else
+ if (!err_ind_pdu) {
LOGPSBCAPC(link, LOGL_ERROR,
- "Tx SBc-AP %s: msg gen failed\n",
- sbcap_pdu_get_name(err_ind_pdu));
+ "Tx SBc-AP Error-Indication: msg gen
failed\n");
+ } else if (cbc_sbcap_link_tx(link, err_ind_pdu) < 0) {
+ LOGPSBCAPC(link, LOGL_ERROR,
+ "Tx SBc-AP Error-Indication
failed\n");
+ }
return 0;
}
break;
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28877
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I9ae1cad4ce4e3fe6cfd67ac6058fb7345a3dd49e
Gerrit-Change-Number: 28877
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-MessageType: merged
