neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-upf/+/29020 )
Change subject: vty doc tweaks
......................................................................
vty doc tweaks
Clarify "Add" and "Delete" of GTP devices.
Clarify GTP device in config vs. real GTP device.
Clarify s/kernel/Linux kernel
Related: SYS#5599
Change-Id: I918e0a9a332e4dd4b71965614c19481eb41004d6
---
M src/osmo-upf/upf_vty.c
M tests/upf.vty
2 files changed, 8 insertions(+), 7 deletions(-)
Approvals:
Jenkins Builder: Verified
neels: Looks good to me, approved
diff --git a/src/osmo-upf/upf_vty.c b/src/osmo-upf/upf_vty.c
index 386aa2f..5227dba 100644
--- a/src/osmo-upf/upf_vty.c
+++ b/src/osmo-upf/upf_vty.c
@@ -86,7 +86,7 @@
DEFUN(cfg_gtp, cfg_gtp_cmd,
"gtp",
- "Enter the 'gtp' node to configure GTP kernel module usage\n")
+ "Enter the 'gtp' node to configure Linux GTP kernel module usage\n")
{
vty->node = GTP_NODE;
return CMD_SUCCESS;
@@ -135,7 +135,8 @@
DEFUN(cfg_gtp_dev_create, cfg_gtp_dev_create_cmd,
"dev create DEVNAME [LISTEN_ADDR]",
DEV_STR
- "create a new GTP device. Will listen on GTPv1 port "
OSMO_STRINGIFY_VAL(PORT_GTP1_U)
+ "Add GTP device, creating a new Linux kernel GTP device. Will listen on
GTPv1 port "
+ OSMO_STRINGIFY_VAL(PORT_GTP1_U)
" and GTPv0 port " OSMO_STRINGIFY_VAL(PORT_GTP0_U) " on the specified
interface, or on ANY if LISTEN_ADDR is"
" omitted.\n"
"device name, e.g. 'apn0'\n"
@@ -154,7 +155,7 @@
DEFUN(cfg_gtp_dev_use, cfg_gtp_dev_use_cmd,
"dev use DEVNAME",
DEV_STR
- "use an existing GTP device, e.g. created by 'gtp-link'\n"
+ "Add GTP device, using an existing Linux kernel GTP device, e.g. created
by 'gtp-link'\n"
"device name, e.g. 'apn0'\n")
{
struct gtp_vty_cfg_dev *d = talloc_zero(g_upf, struct gtp_vty_cfg_dev);
@@ -168,7 +169,7 @@
DEFUN(cfg_gtp_dev_del, cfg_gtp_dev_del_cmd,
"dev delete DEVNAME",
DEV_STR
- "Remove a GTP device from the configuration, and delete the device if it
was created here.\n"
+ "Remove a GTP device from the configuration, and delete the Linux kernel
GTP device if it was created here.\n"
"device name, e.g. 'apn0'\n")
{
const char *dev_name = argv[0];
diff --git a/tests/upf.vty b/tests/upf.vty
index 107909b..d1cebe5 100644
--- a/tests/upf.vty
+++ b/tests/upf.vty
@@ -23,9 +23,9 @@
OsmoUPF(config-gtp)# dev?
dev Configure the GTP device to use for encaps/decaps.
OsmoUPF(config-gtp)# dev ?
- create create a new GTP device. Will listen on GTPv1 port 2152 and GTPv0
port 3386 on the specified interface, or on ANY if LISTEN_ADDR is omitted.
- use use an existing GTP device, e.g. created by 'gtp-link'
- delete Remove a GTP device from the configuration, and delete the device if
it was created here.
+ create Add GTP device, creating a new Linux kernel GTP device. Will listen
on GTPv1 port 2152 and GTPv0 port 3386 on the specified interface, or on ANY if
LISTEN_ADDR is omitted.
+ use Add GTP device, using an existing Linux kernel GTP device, e.g.
created by 'gtp-link'
+ delete Remove a GTP device from the configuration, and delete the Linux
kernel GTP device if it was created here.
OsmoUPF(config-gtp)# dev create ?
DEVNAME device name, e.g. 'apn0'
OsmoUPF(config-gtp)# dev create foo ?
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29020
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I918e0a9a332e4dd4b71965614c19481eb41004d6
Gerrit-Change-Number: 29020
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofm...@sysmocom.de>
Gerrit-MessageType: merged
