Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29028 )
Change subject: osmux.h: Add missing msgb.h header ...................................................................... Patch Set 1: (1 comment) File include/osmocom/netif/osmux.h: https://gerrit.osmocom.org/c/libosmo-netif/+/29028/comment/2461fffa_2d9312ba PS1, Line 6: #include <osmocom/core/msgb.h> > I don't like adding forward declarations of structs coming from other > libraries. […] I see other [lib]osmo* projects having a forward declaration of 'struct msgb' in some header files. This reduces compile time. I do not insist, but I would still prefer this approach. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I2002ed2352ef4db2fe0717389f1f6e24a88a973f Gerrit-Change-Number: 29028 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 11 Aug 2022 14:43:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
