Attention is currently required from: neels, pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28986 )
Change subject: GTP mockup: list active GTP endecaps actions ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > I personally see no reason for using the mockup stuff in the ttcn3 tests, and > hence no reason for th […] I tend to agree with pespin's assessment. We shouldn't have development/debug only features [enabled] in normal production builds. Particularlly not if they make it look like some objects existed, while in reality they don't. Looks like a huge source of potential user confusion. Also, for the TTCN-3 tests, I think in general the goal should be to run the unmodified program just like in production, with all of its interfaces etc. If for some reason we cannot do that in our existing normal jenkins slaves or docker containers, we can always use some kind of special slaves (we already do for example for testing the E1 / frame relay bits. So I think if some testing/mocking is happening, it should happen on the tester (application, OS, VM, ...) side, and not inside the implementation-under-test. VTY tests is a different special case, and we're not arguing about that here. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752 Gerrit-Change-Number: 28986 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Thu, 11 Aug 2022 19:07:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
