Patch Set 1:

(1 comment)

what was the cause for you needing this change? Apparently the tests work fine 
on our build slaves though they have both py2 and py3? I didn't face any such 
problems on my box either, AFAICT?

(BTW, in general, an alternative could be to move to the 
osmo_verify_transcript_{vty,ctrl}.py way, as is used e.g. in osmo-hlr. Not sure 
about the more complex tests here though.)

https://gerrit.osmocom.org/#/c/5022/1/tests/ctrl_test_runner.py
File tests/ctrl_test_runner.py:

Line 1: #!/usr/bin/env python2
I think I had a patch like this somewhere a longish time ago, and it failed on 
FreeBSD. IIUC we're not going to spend more effort on supporting FreeBSD ... 
and it would be easy to provide a symlink on such a system. So I'd be fine with 
this, just wanted to mention the history.


-- 
To view, visit https://gerrit.osmocom.org/5022
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id22e157d1bee453babdfa7ed04c506390b0f17bb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-HasComments: Yes

Reply via email to