Patch Set 3: Code-Review-1 (3 comments)
sorry to have to annoy once more, but it needs to be safe plz https://gerrit.osmocom.org/#/c/4779/3/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: Line 1283: unrelated ws Line 1296: g_cfg->trunk.number_endpoints = g_cfg->trunk.vty_number_endpoints; -1: rather assign the number of allocated endpoints only after allocation, otherwise we will have a similar problem of for-loops iterating over an array that has not been allocated. Line 1305: trunk->number_endpoints = trunk->vty_number_endpoints; same -- To view, visit https://gerrit.osmocom.org/4779 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3994af016fb96427263edbba05f560743f85fdd4 Gerrit-PatchSet: 3 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
