Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/#/c/5006/1/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:

Line 58:         'bts[].direct_pcu': schema.BOOL_STR,
> "direct PCU"? do we have an indirect PCU as well? AFAIK osmo-pcu always nee
See this option from osmo-bts-symo:
"-M   --pcu-direct    Force PCU to access message queue for"

The indirect pcu is the default one, in which the pcu has no direct access to 
firmware/hw but instead received the data from osmo-bts through the unix 
socket. In the direct mode, only signalling is sent bts<->pcu, and the pcu 
fetches the data directly from the firmware. This mode is only supported so far 
by osmo-bts-sysmo (afaik). Actually, for sysmobts, the non-direct path is 
currently not working (I started investigating it and created a task to follow 
it later).


https://gerrit.osmocom.org/#/c/5006/1/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl
File src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl:

PS1, Line 65: gprs
> probably one would want to have a template here to decide if GPRS or EGPRS 
Indeed, but I never used egprs so far, so I didn't include it yet. We can leave 
it for next step in patch series. Do we need any other EGPRS config other than 
changing this line to egprs?


PS1, Line 66: 0
> I'm not sure if RAC=0 is valid. LAC=0 has special meaning (MS detached), so
I'll look into having an increasing RAC then.
Reminder: check that we don't use LAC=0 when incrementing the value.


PS1, Line 68: 1800
> the BVCI must be different for each BTS/PCU that connects to the SGSN.  My 
Thanks, I'll do that then, or use an incrementing counter, same as LAC and RAC.


-- 
To view, visit https://gerrit.osmocom.org/5006
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01485c5d74e5fe62d0ffea9eb1fad29041426eef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-HasComments: Yes

Reply via email to