Patch Set 6: (1 comment)
https://gerrit.osmocom.org/#/c/4906/6/src/libosmo-mgcp/mgcp_msg.c File src/libosmo-mgcp/mgcp_msg.c: Line 346: "endpoint:%x invalid ConnectionIdentifier (empty)\n", > ... I don't understand why you keep insisting on using a LOG line formatting that's inconsistent with all of the existing log statements in the MGW/MGCP code. Please don't apply "general rules" but most and foremost ensure it is consistent within one program. If it needs to be changed, then one has to change all occurrences in a separate patch. -- To view, visit https://gerrit.osmocom.org/4906 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0531a1b670d00cec50078423a2868207135b2436 Gerrit-PatchSet: 6 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-HasComments: Yes
