Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/29699 )

Change subject: vlr: implement fallback to no-auth
......................................................................


Patch Set 1:

(3 comments)

Patchset:

PS1:
+1 when youfix linter issues.


File src/libvlr/vlr_access_req_fsm.c:

https://gerrit.osmocom.org/c/osmo-msc/+/29699/comment/35204d55_ac3a9886
PS1, Line 458:                  proc_arq_fsm_done(fi, cause? *cause : 
GSM48_REJECT_NETWORK_FAILURE);
> spaces required around that '?' (ctx:VxW)

Please fix.


File src/libvlr/vlr_lu_fsm.c:

https://gerrit.osmocom.org/c/osmo-msc/+/29699/comment/781b270c_8ab1be04
PS1, Line 1165:                         lu_fsm_failure(fi, res? *res : 
GSM48_REJECT_NETWORK_FAILURE);
> spaces required around that '?' (ctx:VxW)

Please fix.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29699
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I5feda196fa481dd8a46b0e4721c64b7c6600f0d1
Gerrit-Change-Number: 29699
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Oct 2022 13:55:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to