Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/29853 )

Change subject: AMR->IuUP: do not crash on AMR data before IuUP Init
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File src/libosmo-mgcp/mgcp_iuup.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/29853/comment/25ad8cbd_fa280716
PS1, Line 102:          return -1;
It would be great to have some comment explaining what !irp means here: the 
conn has not yet received/sent IuUP Init yet so it is not yet configured.



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29853
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id9efb7e523d8d9af988e4bf4f5e925839204f934
Gerrit-Change-Number: 29853
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Oct 2022 08:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to