Attention is currently required from: neels, fixeria.
osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/29836 )

Change subject: gsm48_parse_meas_rep: fix parsing multi-band list
......................................................................


Patch Set 3:

(3 comments)

File src/osmo-bsc/gsm_04_08_rr.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/29836/comment/e86c028d_cf583026
PS2, Line 770: TS 04.08
> FYI: TS 44.018 is a more recent version of TS 04. […]
thanks, done


https://gerrit.osmocom.org/c/osmo-bsc/+/29836/comment/4245c22b_fd26016f
PS2, Line 775: struct bitvec *nbv
> const
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/29836/comment/839f7700_fae834b2
PS2, Line 780: arfcn = 0
> "In each BCCH channel sub list the absolute RF channel numbers are placed in 
> increasing order of ARF […]
good catch! this wasn't implemented correctly, fixed in patchset 3.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29836
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic5e4f0531e08685460948b102367825588d839ba
Gerrit-Change-Number: 29836
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Oct 2022 11:01:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to