Attention is currently required from: pespin.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/29860 )

Change subject: mgw: Log unexpected RTP AMR OA-vs-BE payload
......................................................................


Patch Set 1:

(1 comment)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/29860/comment/504d27ec_b465ca64
PS1, Line 1541:                                      " Check your config!\n",
i'd drop "Check your config!", because it is confusing. As a user reading this 
i would expect that i need to adjust some osmo-mgw.cfg item to fix it, but 
instead OA vs BE is decided by the MGCP client, and may not originate from a 
particular config at all, but e.g. from SDP received from a remote entity.



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29860
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib5ae82c01153398491b21191a8cec9969337bbbc
Gerrit-Change-Number: 29860
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-CC: neels <nhofm...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Oct 2022 19:45:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to