Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29865 )
Change subject: mgw: Rename s/mgcp_send_rtp/mgcp_rtp_conn_dispatch_rtp/ ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/29865/comment/9fd3f384_feb19791 PS1, Line 986: rs might as well fix this typo too while at it (and use full line width maybe) https://gerrit.osmocom.org/c/osmo-mgw/+/29865/comment/e1a934e8_c255362e PS1, Line 987: static int mgcp_rtp_conn_dispatch_rtp(struct mgcp_conn_rtp *conn_dst, struct msgb *msg) mgcp_conn_rtp_dispatch_rtp() the struct is called 'mgcp_conn_rtp', we have three functions in the form 'mgcp_conn_rtp_*' matching the struct name, and two mismatching 'mgcp_rtp_conn_*' -- maybe it would be better to stick with a name matching the struct name. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idaf791997b8438a4aede50f614afa0d55ad41faa Gerrit-Change-Number: 29865 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 24 Oct 2022 20:45:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
