Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29876 )
Change subject: vty: Fix and deprecate typo in cmd 'amr-payload bandwith-efficient' ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29876/comment/a8192d04_ed4abc01 PS1, Line 3219: "payload fields packed (AoIP) (DEPRECATED option with typo)\n") We don't really want this deprecated variant to be present in documentation and shown in the VTY help, right? I suggest defining an alias as follows: ALIAS_DEPRECATED(cfg_net_msc_amr_octet_align, deprecated_cfg_net_msc_amr_octet_align_cmd, "amr-payload bandwith-efficient", "Set AMR payload framing mode\n" "payload fields packed (AoIP)\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29876 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iefbadea374974587a421ec981e246b87c7b5de59 Gerrit-Change-Number: 29876 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 26 Oct 2022 10:25:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
