Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29696 )
Change subject: vlr_lu_fsm: clarify naming of static functions ...................................................................... Patch Set 2: -Code-Review (1 comment) File src/libvlr/vlr_access_req_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/29696/comment/bd17465b_afd90792 PS2, Line 323: { same here. "try_auth" sounds like "please try to authenticate", not like a function that tells us whether we should try to authenticate. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29696 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0ea90476470109134411255ffd1f11d88236c91b Gerrit-Change-Number: 29696 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Thu, 27 Oct 2022 10:39:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
