arehbein has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29961 )

Change subject: Fix missing quotes for possibly unresolved variables in shell 
test-statements
......................................................................

Fix missing quotes for possibly unresolved variables in shell test-statements

Related: OS#5736

Change-Id: I7e7f4f95d1a7cc886360c733908c63a2843b0906
---
M ttcn3-dumpcap-start.sh
M ttcn3-tcpdump-start.sh
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ttcn3-dumpcap-start.sh b/ttcn3-dumpcap-start.sh
index 3aec9b9..eb390fd 100755
--- a/ttcn3-dumpcap-start.sh
+++ b/ttcn3-dumpcap-start.sh
@@ -30,7 +30,7 @@
 kill_rm_pidfile $PIDFILE_NETCAT
 kill_rm_pidfile $PIDFILE_PCAP

-if [ ! -x $DUMPCAP ]; then
+if [ ! -x "$DUMPCAP" ]; then
        echo "Missing required dumpcap binary at ${DUMPCAP}"
        exit 31
 fi
diff --git a/ttcn3-tcpdump-start.sh b/ttcn3-tcpdump-start.sh
index 0ce07cd..8433c80 100755
--- a/ttcn3-tcpdump-start.sh
+++ b/ttcn3-tcpdump-start.sh
@@ -35,7 +35,7 @@
        CMD="sudo $TCPDUMP -U"
 fi

-if [ -x $DUMPCAP ]; then
+if [ -x "$DUMPCAP" ]; then
     CAP_ERR="1"
     if [ -x /sbin/setcap ]; then
        # N. B: this check requires libcap2-bin package

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29961
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7e7f4f95d1a7cc886360c733908c63a2843b0906
Gerrit-Change-Number: 29961
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehb...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehb...@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged

Reply via email to