laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29981 )
Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Support building with -Werror=strict-prototypes / -Werror=old-style-definition Unfortunately "-std=c99" is not sufficient to make gcc ignore code that uses constructs of earlier C standards, which were abandoned in C99. See https://lwn.net/ml/fedora-devel/y1kvf35wozzgb...@redhat.com/ for some related discussion. Change-Id: I98a3c0d5cfda2c4b020652efb4f445f8288342b6 --- M src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c M src/libosmo-mgcp-client/mgcp_client_fsm.c M src/osmo-mgw/mgw_main.c M tests/mgcp/mgcp_test.c M tests/mgcp_client/mgcp_client_test.c 5 files changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c b/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c index b8f09d5..a01bbdc 100644 --- a/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c +++ b/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c @@ -227,7 +227,7 @@ static char osmo_mgcpc_ep_fsm_event_name_bufs[32][32] = {}; -static void fill_event_names() +static void fill_event_names(void) { int i; for (i = 0; i < (ARRAY_SIZE(osmo_mgcpc_ep_fsm_event_names) - 1); i++) { @@ -243,7 +243,7 @@ } } -static __attribute__((constructor)) void osmo_mgcpc_ep_fsm_init() +static __attribute__((constructor)) void osmo_mgcpc_ep_fsm_init(void) { OSMO_ASSERT(osmo_fsm_register(&osmo_mgcpc_ep_fsm) == 0); fill_event_names(); diff --git a/src/libosmo-mgcp-client/mgcp_client_fsm.c b/src/libosmo-mgcp-client/mgcp_client_fsm.c index 1a2b6d8..660f0ad 100644 --- a/src/libosmo-mgcp-client/mgcp_client_fsm.c +++ b/src/libosmo-mgcp-client/mgcp_client_fsm.c @@ -760,7 +760,7 @@ return buf; } -static __attribute__((constructor)) void osmo_mgcp_client_fsm_init() +static __attribute__((constructor)) void osmo_mgcp_client_fsm_init(void) { OSMO_ASSERT(osmo_fsm_register(&fsm_mgcp_client) == 0); } diff --git a/src/osmo-mgw/mgw_main.c b/src/osmo-mgw/mgw_main.c index 71b1f1e..7a76210 100644 --- a/src/osmo-mgw/mgw_main.c +++ b/src/osmo-mgw/mgw_main.c @@ -95,7 +95,7 @@ /* used by msgb and mgcp */ void *tall_mgw_ctx = NULL; -static void print_help() +static void print_help(void) { printf("Some useful options:\n"); printf(" -h --help is printing this text.\n"); diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index d843d10..2d8dfec 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -2078,7 +2078,7 @@ OSMO_ASSERT(ok); } -void test_conn_id_matching() +void test_conn_id_matching(void) { struct mgcp_endpoint endp = {}; struct mgcp_conn *conn; @@ -2118,7 +2118,7 @@ talloc_free(conn); } -void test_e1_trunk_nr_from_epname() +void test_e1_trunk_nr_from_epname(void) { unsigned int trunk_nr; int rc; @@ -2168,7 +2168,7 @@ return; } -void test_mgcp_is_rtp_dummy_payload() +void test_mgcp_is_rtp_dummy_payload(void) { /* realistic rtp packet */ static const char rtp_payload[] = diff --git a/tests/mgcp_client/mgcp_client_test.c b/tests/mgcp_client/mgcp_client_test.c index 9f09a99..ef05adc 100644 --- a/tests/mgcp_client/mgcp_client_test.c +++ b/tests/mgcp_client/mgcp_client_test.c @@ -315,7 +315,7 @@ msgb_free(msg); } -void test_mgcp_client_cancel() +void test_mgcp_client_cancel(void) { mgcp_trans_id_t trans_id; struct msgb *msg; @@ -487,7 +487,7 @@ }, }; -void test_sdp_section_start() +void test_sdp_section_start(void) { int i; int failures = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I98a3c0d5cfda2c4b020652efb4f445f8288342b6 Gerrit-Change-Number: 29981 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-MessageType: merged
