Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29996 )
Change subject: Improve MS logging ...................................................................... Patch Set 2: (2 comments) File src/gprs_ms.c: https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/960600d8_a7b01abd PS2, Line 1030: if (tlli != GSM_RESERVED_TMSI) > For the sake of explicitness, I would print TLLI unconditionally. I see no need to print some long value here if it is unknown, we better use avaialble space for printing intersting stuff since there's lots of interesting info to print and the log ends up already quite full. So no, I really prefer not printing stuff which is not relevant. Absence of it already tells you there's none assigned/known. https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/109b54c4_7069f3fa PS2, Line 1032: PRIu8 "-%" PRIu8 > I suggest prefixing the values with 'G' and 'E', respectively. […] I'd like to keep the lines as short as possible so I'd rather avoid adding that. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If9b325764c8fd540d60b6419f32223fd7f5a5898 Gerrit-Change-Number: 29996 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-CC: osmith <osm...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Fri, 04 Nov 2022 09:40:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
