Attention is currently required from: pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30101 )
Change subject: trxcon: reorganize the core logic into libtrxcon.la ...................................................................... Patch Set 1: (1 comment) File src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30101/comment/1128df16_5b710dc3 PS1, Line 34: struct trxcon_log_cfg { > this will break ABI next time you want to add a new category and old client > uses newer version of th […] agreeing with pau. or (more ugly) turn it into an array that has a number of reserved elements that can be used in the future without breaking the size of this struct. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idf207947f620a7394e0a0e5bf2c37bcd8df64bbe Gerrit-Change-Number: 30101 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 10:40:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment