Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30127 )
Change subject: WIP: dumpcap-start/stop: Make script fail, not hang on sudo prompt ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Patchset: PS1: You are doing up to 3 different things here, please split aproppiately and describe better. - "-e" option output stuff - Using "sudo" for whatever reason - Not hang when using sudo File ttcn3-dumpcap-start.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30127/comment/1ac1af2b_18838982 PS1, Line 19: sudo -k this is dropping the sudo password from my currently active shell? Meanng each time after running any testsuite I need to retype my password? no thanks ;) Better remove it. BTW, why do you need sudo here? isn't dumpcap getting cap_net_admin,cap_net_raw below? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: arehbein/ttcn3-dumpcap-changes Gerrit-Change-Id: Id160384bf624a4eb0f419cb8ba07d8b69bb693f3 Gerrit-Change-Number: 30127 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehb...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: arehbein <arehb...@sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 12:15:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
