Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30126 )
Change subject: [codecs filter] use filter result ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: looking at this patch again, it looks rather unclear why the codecs filter result ends up in assignment... it looks much cleaner in a later patch, where i must still investigate a minor odd change in MNCC behavior. I adjusted the commit log to explain... I think i will wait until that follow up patch is ready before submitting a new patch set. BTW, it is super complex to explain the legacy code and its transition to a new implementation, i'm beginning to think i should just have secretly merged that code bomb without anyone noticing, instead of kneading through all of these weird details ;) File tests/msc_vlr/msc_vlr_test_call.err: https://gerrit.osmocom.org/c/osmo-msc/+/30126/comment/09923322_ae1f2455 PS1, Line 320: MGW <--CRCX to RTP_TO_CN-- MSC: callref=0x80000001 codecs=VND.3GPP.IUFP#96 > Is this change AMR->IUFP expected? yes, i also find it curious... note that the surrounding logging indicates UTRAN, so I expect that previous code erratically used AMR in the first CRCX instead of the IUFP that we are actually (so far) feeding through to the CN. It is definitely correct to show IUFP here. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I66e7c8c5e401f4f3a7d3d42b9525b2c6e99691d9 Gerrit-Change-Number: 30126 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 17 Nov 2022 00:31:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
