Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30262 )
Change subject: trxcon: implement Ready-to-Receive PHYIF API ...................................................................... Patch Set 2: (3 comments) File src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30262/comment/8a6ea44b_3b48fd5d PS2, Line 166: #define L1SCHED_PROBE_F_ACTIVE (1 << 0) That looks odd. Why not simply put 1? File src/host/trxcon/include/osmocom/bb/trxcon/phyif.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30262/comment/63baaeb5_10315d17 PS2, Line 85: #define TRXCON_PHYIF_RTR_F_ACTIVE (1 << 0) Same here. File src/host/trxcon/src/sched_trx.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30262/comment/e81094e2_7a6861eb PS2, Line 829: return -ENODEV; Would be better to use different error code to distinguish between different errors. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9a71b8a59733f4dd908b760c5e23ea3d624afb1a Gerrit-Change-Number: 30262 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msur...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Sat, 26 Nov 2022 13:51:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
