Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30301 )
Change subject: osmo-ns-dummy: add rate counters ...................................................................... Patch Set 3: (1 comment) File utils/osmo-ns-dummy.c: https://gerrit.osmocom.org/c/libosmocore/+/30301/comment/99c2ca68_07ca8c73 PS3, Line 56: static const struct rate_ctr_desc dummy_ctr_desc[] = { > That's a program solely used as unit test helper. […] This program is not a placeholder for any kind of tests, it serves a specific purpose. It's used to test NS, not to test rate counters in a generic way. If you want to test rate counters, add a new test or helper program to test those. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7 Gerrit-Change-Number: 30301 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: msuraev <msur...@sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 09:26:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: msuraev <msur...@sysmocom.de> Gerrit-MessageType: comment
