Attention is currently required from: fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30326 )
Change subject: mobile: add MNCC handler selection to settings ...................................................................... Patch Set 1: (2 comments) File src/host/layer23/src/mobile/app_mobile.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30326/comment/829e0ccd_89f74ed7 PS1, Line 249: ms->mncc_entity.sock_state = mncc_sock_init(ms, ms->settings.mncc_socket_path); So sock_state is used only if mncc_handler is "EXTERNAL"? Then better put it under ms->mncc_entity.external.sock_state File src/host/layer23/src/mobile/vty_interface.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30326/comment/3b4e276e_d24997cb PS1, Line 1665: DEFUN(cfg_ms_no_mncc_handler, cfg_ms_no_mncc_handler_cmd, > What's the point of introducing redundant vty command if dummy handler can be > selected with mncc-han […] ACK, specifying the default above in the description (like you did) should be enough for the user to set the mncc-handler to default. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2df91c7a79ba5c39bc6ceae900ef649129dd0346 Gerrit-Change-Number: 30326 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: msuraev <msur...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: msuraev <msur...@sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 09:33:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msur...@sysmocom.de> Gerrit-MessageType: comment
