pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30344 )

Change subject: vty: Fix lost 'no timer-dynamic T3113' config when writing 
current config
......................................................................

vty: Fix lost 'no timer-dynamic T3113' config when writing current config

The default is to have a dynamic T3113. However, if the user wished to
set it statically, it would show up when writing the current VTY config.

Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d
---
M src/osmo-bsc/bts_vty.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c
index e01d9b8..50e49b8 100644
--- a/src/osmo-bsc/bts_vty.c
+++ b/src/osmo-bsc/bts_vty.c
@@ -3033,7 +3033,7 @@
 #define TNUM_STR "T-number, optionally preceded by 't' or 'T'\n"
 DEFUN_ATTR(cfg_bts_t3113_dynamic, cfg_bts_t3113_dynamic_cmd,
           "timer-dynamic TNNNN",
-          "Calculate T3113 dynamically based on channel config and load\n"
+          "Calculate T3113 dynamically based on channel config and load 
(default)\n"
           TNUM_STR,
           CMD_ATTR_IMMEDIATE)
 {
@@ -4516,6 +4516,8 @@
        /* if we have a limit, write it */
        if (bts->paging.free_chans_need >= 0)
                vty_out(vty, "  paging free %d%s", bts->paging.free_chans_need, 
VTY_NEWLINE);
+       if (!bts->T3113_dynamic)
+               vty_out(vty, "  no timer-dynamic T3113%s", VTY_NEWLINE);

        vty_out(vty, "  neighbor-list mode %s%s",
                get_value_string(bts_neigh_mode_strs, 
bts->neigh_list_manual_mode), VTY_NEWLINE);

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30344
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If121a97bbb4a0234a0c162ef37c3692d6408404d
Gerrit-Change-Number: 30344
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged

Reply via email to