Attention is currently required from: pespin, fixeria.
Hoernchen has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/30415 )

Change subject: vita demod by piotr krysik, modified
......................................................................


Patch Set 3:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/57c38754_c059e099
PS2, Line 7: by piotr krysik
> Commit message should ideally state where the code is imported from, 
> including the commit hash if it […]
Done


File Transceiver52M/grgsm_vitac/viterbi_detector.cc:

https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c83d3f0f_fdee178b
PS2, Line 1: /* -*- c++ -*- */
> All files are named ".cpp", why is this one named ". […]
nothing to fix here, this file is a literal copy of the grgsm code and it 
should stay that way, also obove.



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f
Gerrit-Change-Number: 30415
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ew...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 14:43:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to