laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30405 )
Change subject: pfcp coding errmsgs: drop extra newlines ...................................................................... pfcp coding errmsgs: drop extra newlines Change-Id: I4eea1efc9bd67676b6202e50d41974b2717a2511 --- M src/libosmo-pfcp/pfcp_ies_custom.c 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/libosmo-pfcp/pfcp_ies_custom.c b/src/libosmo-pfcp/pfcp_ies_custom.c index 3531e02..1891902 100644 --- a/src/libosmo-pfcp/pfcp_ies_custom.c +++ b/src/libosmo-pfcp/pfcp_ies_custom.c @@ -813,42 +813,42 @@ s_tag = osmo_pfcp_bits_get(ohc->desc_bits, OSMO_PFCP_OUTER_HEADER_CREATION_S_TAG); if ((gtp_u_udp_ipv4 || gtp_u_udp_ipv6) != (ohc->teid_present)) - RETURN_ERROR(-EINVAL, "teid_present = %s does not match the description bits 0x%02x\n", + RETURN_ERROR(-EINVAL, "teid_present = %s does not match the description bits 0x%02x", ohc->teid_present ? "true" : "false", ohc->desc_bits[0]); if (ohc->teid_present) msgb_put_u32(tlv->dst, ohc->teid); if ((gtp_u_udp_ipv4 || udp_ipv4 || ipv4) != ohc->ip_addr.v4_present) - RETURN_ERROR(-EINVAL, "ipv4_addr_present = %s does not match the description bits 0x%02x\n", + RETURN_ERROR(-EINVAL, "ipv4_addr_present = %s does not match the description bits 0x%02x", ohc->ip_addr.v4_present ? "true" : "false", ohc->desc_bits[0]); if (ohc->ip_addr.v4_present) osmo_sockaddr_to_octets(msgb_put(tlv->dst, 4), 4, &ohc->ip_addr.v4); if ((gtp_u_udp_ipv6 || udp_ipv6 || ipv6) != ohc->ip_addr.v6_present) - RETURN_ERROR(-EINVAL, "ipv6_addr_present = %s does not match the description bits 0x%02x\n", + RETURN_ERROR(-EINVAL, "ipv6_addr_present = %s does not match the description bits 0x%02x", ohc->ip_addr.v6_present ? "true" : "false", ohc->desc_bits[0]); if (ohc->ip_addr.v6_present) osmo_sockaddr_to_octets(msgb_put(tlv->dst, 16), 16, &ohc->ip_addr.v6); if ((udp_ipv4 || udp_ipv6) != ohc->port_number_present) - RETURN_ERROR(-EINVAL, "port_number_present = %s does not match the description bits 0x%02x\n", + RETURN_ERROR(-EINVAL, "port_number_present = %s does not match the description bits 0x%02x", ohc->port_number_present ? "true" : "false", ohc->desc_bits[0]); if (ohc->port_number_present) msgb_put_u16(tlv->dst, ohc->port_number); if (c_tag != ohc->c_tag_present) - RETURN_ERROR(-EINVAL, "c_tag_present = %s does not match the description bits 0x%02x%02x\n", + RETURN_ERROR(-EINVAL, "c_tag_present = %s does not match the description bits 0x%02x%02x", ohc->c_tag_present ? "true" : "false", ohc->desc_bits[1], ohc->desc_bits[0]); if (ohc->c_tag_present) osmo_store32be_ext(ohc->c_tag, msgb_put(tlv->dst, 3), 3); if (s_tag != ohc->s_tag_present) - RETURN_ERROR(-EINVAL, "s_tag_present = %s does not match the description bits 0x%02x%02x\n", + RETURN_ERROR(-EINVAL, "s_tag_present = %s does not match the description bits 0x%02x%02x", ohc->s_tag_present ? "true" : "false", ohc->desc_bits[1], ohc->desc_bits[0]); if (ohc->s_tag_present) -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I4eea1efc9bd67676b6202e50d41974b2717a2511 Gerrit-Change-Number: 30405 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-MessageType: merged