Patch Set 1:

> are we sure that the individual programs each actually use all of
 > the libraries you have listed in their CFLAGS now?  We typically
 > don't list all libraries' CFLAGS for each of the programs/libraries.
 >  We only do so, if they actually use definitions/symbols from that
 > library.

Yes, all additions are based on actual build failures in my environment in 
which libraries are installed in distinct directories and then symlinked to a 
common one with GNU stow.
Please see also https://gerrit.osmocom.org/#/c/2691 which would help in 
detecting such missing entries.

-- 
To view, visit https://gerrit.osmocom.org/5138
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67b5d797a80b55e01dcdbb8c782748b049cf9199
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Alexander Huemer <alexander.hue...@xx.vu>
Gerrit-Reviewer: Alexander Huemer <alexander.hue...@xx.vu>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

Reply via email to