Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30564 )
Change subject: Move control_ts explicit checks out of the scheduler implementation ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/30564/comment/d123dbae_040b2370 PS2, Line 9: Let each subsystem handle that internally. > I understand what this patch is doing, but would like see the motivation > explained here. I'm just trying to refactor all stuff related to how the control TS is assigned to a TBF, which is currently a nightmare, since it works differently in different cases like upgrading a DL TBF to be multislot, upgrading a UL TBF multislot afer PktResourceReq, etc. I'll probably end up having to tweak something specific for the first case I mentioned, hence I prefer having specific checks in each RTS function. In any case, I think it's good removing as much extra logic as possible from the scheduler and leave that to the RTS functions. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifaf7dde651d56942779d84aa9135fc8c974b6f26 Gerrit-Change-Number: 30564 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Wed, 14 Dec 2022 11:53:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
