Attention is currently required from: laforge, pespin, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28849 )
Change subject: libosmonetify SMPP ...................................................................... Patch Set 61: (4 comments) File src/libsmpputil/smpp_smsc.c: https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/856e20e5_31b3bde1 PS49, Line 238: if (esme->use < 0) > Actually changing this check makes half of TTCN3 tests fail so I'd rather not > mess with resource cou […] Done https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/bcdfc3e4_69c0b740 PS49, Line 825: static int esme_link_read_cb(struct osmo_stream_srv *conn) > Indeed, better rename it and make static. […] Done https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/dad4182a_6c7e5517 PS49, Line 851: static int esme_link_close_cb(struct osmo_stream_srv *conn) > Simply give a look at the code. For instance: […] Done File src/libsmpputil/smpp_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/5dd757de_0e88a90b PS49, Line 83: bool is_running = smsc->link; > Sure, if it was used more than once. For a single call I don't think it's > worth it. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idc2e60af1010783e555e61b114ae61f55a89d890 Gerrit-Change-Number: 28849 Gerrit-PatchSet: 61 Gerrit-Owner: msuraev <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Sun, 18 Dec 2022 16:53:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: msuraev <msur...@sysmocom.de> Gerrit-MessageType: comment
