Patch Set 3: Code-Review+1

> I don't have equipment right now to test this, but the code looks
 > good on the first glance.
 > 
 > Just one comment - is this requirement of sending the first frame
 > number documented in the parameters of the relevant functions? That
 > would be great to have it there to avoid mistakes in future.

I have tried it out, I could reproduce the problem. With the patch it works 
fine again. I have tested it on TS0-7 in TCH/H and TCH/F mode.

-- 
To view, visit https://gerrit.osmocom.org/5136
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1065ae9c400bb5240a63ab8213aee59aeb9ceeff
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Alexander Chemeris <alexander.cheme...@gmail.com>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-HasComments: No

Reply via email to