Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/5008/2/src/osmo_gsm_tester/bts_octphy.py File src/osmo_gsm_tester/bts_octphy.py: Line 177: config.overlay(values, sgsn_conf) > heh, why not What would happen then? because self.sgsn is None in that case. Does overlay() actually handle that correctly and replaces it with {} ? I don't like the idea of being able to pass None to that method and I'd like to avoid it. This way is more clear to understand what's the result inside overlay. -- To view, visit https://gerrit.osmocom.org/5008 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54780971d711d47b23976dd044a4a53134dd4299 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes
