Attention is currently required from: laforge, fixeria. Hello Jenkins Builder, laforge, fixeria,
I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/30922 to look at the new patch set (#3). Change subject: abis_rsl: fix frame number calculation ...................................................................... abis_rsl: fix frame number calculation The formula that is used to recover the (relative) frame number from the T1, T2, T3 parameters matches the definition in the spec, but since the partial term t3-t2 can be negative special precaution is required when performing the MOD 26 operation. This is due to the truncated modulo implementation in C/C++, which has a very specific understanding on how to deal with negative input parameters. The libosmocore gsm_gsmtime2fn(() offers a correct implementation, so lets use it. Change-Id: I5fb2b0ada8d409730ac22963741fb4ab0026abdd Related: OS#5198 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/22/30922/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5fb2b0ada8d409730ac22963741fb4ab0026abdd Gerrit-Change-Number: 30922 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: newpatchset