Attention is currently required from: msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715 )
Change subject: rate counter: add StatsD note ...................................................................... Patch Set 3: (2 comments) File common/chapters/counters-overview.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715/comment/8c052da2_9781a833 PS2, Line 127: does > The agreed upon limit is 120 which is way more convenient than 80. I can see that it's more convenient for code, but IMHO text is more readable with lines that aren't as long. The coding standards says _up_to_ 120 characters, as I understand it's fine to use less characters in a line where it makes sense. I'd keep it at 80 characters for readability and so it's consistent with the rest of the file. But this is cosmetics, if you insist then just ignore this review point. https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715/comment/dac1989b_8dbc4013 PS2, Line 129: StatsD > The rest of the file can be fixed in a separate commit (unless we're talking > about the name of the b […] I mean, it would be good to have consistent spelling of it. in your patch its "statsd", "StatsD" and "statsD" ;) So I suggest using the spelling that was already used in this document for consistency, which is "statsd". If you want to change it in the existing document, IMHO it should be done as separate patch before this one to keep consistency. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I124503c3707bbe005abbfb4245abe2829c6ff57c Gerrit-Change-Number: 30715 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osm...@sysmocom.de> Gerrit-Attention: msuraev <msur...@sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 08:26:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osm...@sysmocom.de> Comment-In-Reply-To: msuraev <msur...@sysmocom.de> Gerrit-MessageType: comment
