Attention is currently required from: pespin.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30994 )
Change subject: layer23: Introduce tun.{c,h}
......................................................................
Patch Set 2:
(19 comments)
File src/host/layer23/include/osmocom/bb/common/tun.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/e6c76432_b2ff40f2
PS2, Line 39: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/b539f401_67396aa5
PS2, Line 39: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/408119bc_1d1e77d1
PS2, Line 53: int (*cb_ind) (struct tun_t * tun, void *pack,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/c8ff476d_1b0526c1
PS2, Line 53: int (*cb_ind) (struct tun_t * tun, void *pack,
Unnecessary space before function pointer arguments
File src/host/layer23/src/common/tun.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/4f5e7f6e_6bfc26a1
PS2, Line 48: #elif defined (__FreeBSD__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/4b974623_86f2fcdb
PS2, Line 53: #elif defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/30a12072_520a6024
PS2, Line 65: #define SYS_ERR(sub, pri, en, fmt, args...)
\
Macros starting with if should be enclosed by a do - while loop to avoid
possible if/else logic defects
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/7077f55e_41a14101
PS2, Line 104: #if defined(__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/cf1593e4_436fd48c
PS2, Line 123: #if defined(__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/9596077f_d6a92cea
PS2, Line 186: #elif defined(__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/e261d027_08c963a2
PS2, Line 214: strcpy(ifr.ifr_name, dev_name);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/baa51f05_0c71a348
PS2, Line 221: strncpy((*tun)->devname, ifr.ifr_name, IFNAMSIZ);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/0bc8c8fa_2fb30731
PS2, Line 229: } else {
else is not generally useful after a break or return
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/609375ad_4f7c403b
PS2, Line 230: strncpy((*tun)->devname, dev_name, IFNAMSIZ);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/3209d461_d41d7b3b
PS2, Line 243: #elif defined(__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/c714d7d9_f2eccfcc
PS2, Line 273: strncpy(areq.ifra_name, (*tun)->devname, IFNAMSIZ);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/1d47c53d_eb7716e8
PS2, Line 283: while (ioctl(fd, SIOCDIFADDR, (void *)&areq) != -1) ;
space prohibited before semicolon
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/bcd6ca32_0a5f35ea
PS2, Line 319: int (*cb_ind) (struct tun_t * tun, void *pack,
unsigned len))
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786):
https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/1dea2092_e07cd7b4
PS2, Line 319: int (*cb_ind) (struct tun_t * tun, void *pack,
unsigned len))
Unnecessary space before function pointer arguments
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30994
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id8611b720ada17a3c602872fe095bb91eeb17bcd
Gerrit-Change-Number: 30994
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Jan 2023 10:02:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
