Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30992 )
Change subject: layer23: Introduce APN VTY node ...................................................................... Patch Set 2: (3 comments) File doc/examples/modem/modem.cfg: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/8289f4c8_4bba7263 PS2, Line 12: no shutdown > 'no shutdown' again? I understand the idea that the user may want to switch > between APNs, or even ac […] I'm just following existing commands (same is used for a long time in osmo-ggsn), which I suppose even comes from old cisco-like VTY namings. File src/host/layer23/include/osmocom/bb/common/apn.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/f450acfb_1d442a36 PS2, Line 62: //struct in6_addr v6_lladdr; > TODO? Yes, I'm focusing on filling holes grain by grain, otherwise it's too many pieces and too much work and patches wouldn't be nice to review. This way also other can use stuff in there earlier while developing their own parts. File src/host/layer23/include/osmocom/bb/common/ms.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/057b9677_209e32f7 PS2, Line 94: gprs_settings > Ideally, all settings should be in struct gsm_settings. I decided to split it into gsm_settings and gprs_settings since other apps may not need the GPRS part. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e Gerrit-Change-Number: 30992 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:38:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
