Attention is currently required from: osmith, laforge, pespin.
Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/31024 )

Change subject: Introduce netns API
......................................................................


Patch Set 4:

(1 comment)

File src/core/netns.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2891):
https://gerrit.osmocom.org/c/libosmocore/+/31024/comment/676ed04b_41c987ab
PS4, Line 122:  rc = mkdir(NETNS_PREFIX_PATH, 
S_IRWXU|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH);
Symbolic permissions 'S_IRWXU|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH' are not 
preferred. Consider using octal permissions '0755'.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31024
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0f2fba2fa42250a07211a7b7f479498f27c529da
Gerrit-Change-Number: 31024
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Attention: osmith <osm...@sysmocom.de>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Jan 2023 19:37:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to