Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/5184/1/src/libmsc/db.c File src/libmsc/db.c: Line 955: free(q_msisdn); > You shouldn't free memory if dbi_conn_quote_string_copy() failed to allocat Agreed. If you look at this file before this patch, I just copied the scheme from the other db code. So arguably, I am following the local scheme and we should fix all of them in a separate patch? -- To view, visit https://gerrit.osmocom.org/5184 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I793a3863e6f4ccbabafc7dabaff97a8c79bbd8e0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
