Patch Set 2: Code-Review+1 (1 comment)
looks sane enough, but would be nice to hint at a caller, given that there is none in this patch https://gerrit.osmocom.org/#/c/4955/2/src/mslot_class.h File src/mslot_class.h: Line 31: #define MS_NA 255 /* N/A */ unrelated cosmetic -- To view, visit https://gerrit.osmocom.org/4955 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31d503af700ec3364042ff7e661710953cacf9f8 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes