Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31423 )
Change subject: L1 IF: Use enums from libosmocore ...................................................................... Patch Set 1: (1 comment) This change is ready for review. File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31423/comment/f08bf114_8d397022 PS1, Line 770: info_ind->nse_timer[NS_TOUT_TNS_BLOCK], info_ind->nse_timer[NS_TOUT_TNS_BLOCK_RETRIES], > for stuff related to PCUIF, you need to add new definitions in pcu_l1_if. […] So here we want definition redundancy, but in the other cases we don't. Wouldn't it also be better here to just use defs that already exist and serve our purpose? I don't quite understand why this case would be different since it's also data passed on the same interface level -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I40ffbfe34591133f514967dbc1c0a62540c52a7a Gerrit-Change-Number: 31423 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehb...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 18:07:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
