Patch Set 2: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/5212/2//COMMIT_MSG Commit Message: Line 9: remove unused variable "ret" in unit test "power" so far so good, but I am all the time talking about the *summary line* above. The point is that when you read an endless list of commit log, you want to know what area of code has changed at the first glance. If there are 1000 commits like "added a function" and "removed a variable" you need to open and read every single commit to figure out whether it is related to the bug you're trying to figure out. Hence, cram as much helpful info as fits in ~60 chars on the summary line, best using actual file names or function name prefixes. This is a rule for all commits all the time forever, always has been, and certainly not the first time I'm asking for this either. cosmetic: foo_bar: frobnicated prismotube I hate to block such a trivial commit but really want to make sure to get this point across, which is very basic and quite important to me. Thanks :) -- To view, visit https://gerrit.osmocom.org/5212 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied484e3e2d3006eb0f03516ceaed3e0e802d51e4 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
