Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/31497 )

Change subject: pcu_sock: activate/deactivate PDCH on pcu reconnect
......................................................................


Patch Set 1:

(3 comments)

File src/osmo-bsc/timeslot_fsm.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3985):
https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/5ef68a69_e37315b2
PS1, Line 344:  if(is_ericsson_bts(bts) && bts->pcu_state->conn_bfd.fd < 0) {
space required before the open parenthesis '('


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3985):
https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/893ec656_38b8f0df
PS1, Line 543:         case TS_EV_PDCH_DEACT:
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3985):
https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/a44bad9e_a447c9cf
PS1, Line 543:         case TS_EV_PDCH_DEACT:
please, no spaces at the start of a line



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31497
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9ea0c53a5e68a51c781ef43bae71f947cdb95678
Gerrit-Change-Number: 31497
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 24 Feb 2023 15:08:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to