Attention is currently required from: arehbein. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/31523 )
Change subject: Transition to use of 'telnet_init_default' ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/gtphub/gtphub_main.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/31523/comment/9f958608_cc279dbd PS1, Line 357: rc = telnet_init_default(osmo_gtphub_ctx, 0, OSMO_VTY_PORT_GTPHUB); The second parameter of telnet_init_default() is void *, so it's better to use NULL, not 0. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/31523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31523 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehb...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msur...@sysmocom.de> Gerrit-Attention: arehbein <arehb...@sysmocom.de> Gerrit-Comment-Date: Sat, 25 Feb 2023 21:11:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment