Attention is currently required from: pespin, fixeria.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/31558 )

Change subject: pcu_l1_if_phy: add header file for struct gsmtap_inst
......................................................................


Patch Set 2:

(1 comment)

File src/pcu_l1_if_phy.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/31558/comment/839c0ed5_7f6728b7
PS2, Line 4: #include <osmocom/core/gsmtap_util.h>
> I find it more correct to add the header here since this declaration is 
> provided by some external de […]
Ack



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31558
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I9b859c4f7906f31547549d4ff7751fb720519270
Gerrit-Change-Number: 31558
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Feb 2023 16:44:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to