Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31545 )
Change subject: lchan.h: remove enum lchan_csd_mode ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/31545/comment/038dcb2f_1dd2b508 PS2, Line 10: But instead we can just : directly translate the BSSAP value to the RSL value. we can, but do we already have a related enum in the ts48_058 header files? After all, a symbolic enum name is much more expressive than some integer values (in the code). The 48.058 split into transparent and non-transparent also makes it slightly more complex to understand, as the uint8_t can have different meanings. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ice914744da3a2084e82d125848fb69404b8e8a36 Gerrit-Change-Number: 31545 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 18:33:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
